Add Compatibility with ST7789 LCD (T-Display S3) #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a great addition! Can you share a photo of how it looks like right now? |
|
I was only able to convert this screen and it still flickers a little. As I said, this is really my first contact with Arduino, what I tried to do was convert what is done with the Adafruit_LiquidCrystal lib to TFT_eSPI.h. That's why I published this PR to have a review. I don't even know about good practices in Arduino :p |
|
It's a good start, much more can be done with a color screen however. I have one on hand with this controller so I'll probably try to add a fancier UI to your baseline in the future |
revoxhere
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to make the code compatible with the ST7789 display used in the T-Display S3 board. This is my first time developing with Arduino, so I’m aware that the code is far from perfect.
The primary motivation for this PR is to open up discussions and gather feedback on how we can improve this implementation. I believe that adding compatibility with the T-Display S3 could significantly increase community engagement, given the popularity of this board.
I'm looking forward to your feedback and suggestions. Thank you for your attention!