Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add fallback memory #736

Merged
merged 3 commits into from
Jun 8, 2023
Merged

✨ Add fallback memory #736

merged 3 commits into from
Jun 8, 2023

Conversation

asim-shrestha
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 1:45am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2023 1:45am

@vercel vercel bot temporarily deployed to Preview – docs June 8, 2023 01:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs June 8, 2023 01:45 Inactive
("reset_class", ()),
],
)
def test_memory_with_fallback(method_name: str, args) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

try:
return self.primary.__enter__()
except Exception as e:
logger.error(e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.error(e)
logger.exception(e)

We will want to setup sentry to catch this eventually

try:
self.primary.__exit__(exc_type, exc_value, traceback)
except Exception as e:
logger.error(e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logger.error(e)
logger.exception(e)

import weaviate

auth = (
weaviate.auth.AuthApiKey(api_key="KNaObeDhRVRaI488QkEoprZ3LriotjRIo6Rg")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... you get the gorilla

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted 💥

@asim-shrestha asim-shrestha merged commit 1a43231 into main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants