-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👟 Footer for landing page #940
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi 👋 Here's a preview environment 🚀 https://next-reworkd-agentgpt-940.env.ergomake.link Environment Summary 📑
Questions? Comments? Suggestions? Join Discord. Click here to disable Ergomake. |
const links = [ | ||
{ | ||
name: "Github", | ||
href: "https://github.com/reworkd/AgentGPT", | ||
icon: FaGithub, | ||
}, | ||
{ | ||
name: "Twitter", | ||
href: "https://twitter.com/ReworkdAI", | ||
icon: FaTwitter, | ||
}, | ||
{ | ||
name: "Discord", | ||
href: "https://discord.gg/gcmNyAAFfV", | ||
icon: FaDiscord, | ||
}, | ||
{ | ||
name: "LinkedIn", | ||
href: "https://www.linkedin.com/company/reworkd/", | ||
icon: FaLinkedin, | ||
}, | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
links.tsx
has this. Lets reuse that - we can also add the LinkedIn link there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that but I want to use the IconType not the component here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally links.tsx should use the icontype aswell. but that can be future
<div className="hidden flex-row gap-3 text-white sm:flex"> | ||
{links.map((link, i) => ( | ||
<a | ||
key={i} | ||
href={link.href} | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
className="transition-all hover:rotate-6 hover:text-purple-400" | ||
> | ||
<span className="sr-only">{link.name}</span> | ||
<link.icon size={24} /> | ||
</a> | ||
))} | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this one for? Its just always hidden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is shows up on large screens, notice the sm:flex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah mb, but we could just add selector styling for the gap and do just two link icons instead of doing two of the entire thing?
<a className="text-center" href="https://reworkd.ai/privacyPolicy" target="_blank"> | ||
Privacy Policy | ||
</a> | ||
<a className="text-center" href="http://reworkd.ai/terms"> | ||
Terms and Conditions | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also place these in the links section. Also, one of these is missing a target="_blank"
Co-authored-by: Asim Shrestha <[email protected]>
relates to #938
Text alignment isn't quite perfect but this can be addressed later