Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol allowlisting for -webkit-image-set CSS function #242

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add protocol allowlisting for -webkit-image-set CSS function #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/sanitize/css.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def property!(prop)
return nil unless valid_url?(child)
end

if name == 'image-set' || name == 'image'
if ['image-set', 'image', '-webkit-image-set'].include?(name)
return nil unless valid_image?(child)
end

Expand Down Expand Up @@ -353,7 +353,7 @@ def valid_url?(node)
# using an allowlisted protocol.
def valid_image?(node)
return false unless node[:node] == :function
return false unless node.key?(:name) && ['image', 'image-set'].include?(node[:name].downcase)
return false unless node.key?(:name) && ['image', 'image-set', '-webkit-image-set'].include?(node[:name].downcase)
return false unless Array === node[:value]

node[:value].each do |token|
Expand Down
3 changes: 3 additions & 0 deletions test/test_sanitize_css.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
"background: image-set('relative.jpg' 1x, 'relative-2x.jpg' 2x)",
"background: image-set('https://example.com/https.jpg' 1x, 'https://example.com/https-2x.jpg' 2x)",
"background: image-set('https://example.com/https.jpg' type('image/jpeg'), 'https://example.com/https.avif' type('image/avif'))",
"background: -webkit-image-set('relative.jpg' 1x, 'relative-2x.jpg' 2x)",
"background: -webkit-image-set('https://example.com/https.jpg' 1x, 'https://example.com/https-2x.jpg' 2x)",
"background: -webkit-image-set('https://example.com/https.jpg' type('image/jpeg'), 'https://example.com/https.avif' type('image/avif'))",
"background: image('relative.jpg');",
"background: image('https://example.com/https.jpg');",
"background: image(rtl 'https://example.com/https.jpg');"
Expand Down