Prevents double targeting on player mon if both ai mons see kill #5297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be willing to add an extremely brief section for the flag to |
Pawkkie
requested changes
Sep 6, 2024
Will add. Also I want to write some tests. |
|
Ready for re-review |
|
There is a bug (the ai recalcs the target but not the move choice) in this so putting in on draft |
I'm now back form my honeymoon so can re-review when you're ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5212. It isn't exactly what was asked in the suggestion but this is a superset of it. I believe the suggestion in the issue ticket isn't good and should not make it into expansion
In vanilla when both AI mons see a kill on a player mon they will pin down the mon with both mons. This pr changes it so the other mon will be targeted by one of the AI mons.
Since this is a superset of the vanilla implementation I made it as default with a vanilla ai flag to turn it off. This could potentially be a config. Additionally or replacing the ai flag.
Examples:
If slot 1 and 3 see kill on slot 2, Slot 1 will first target slot 2 then if Slot 3 targets slot 2 as well, slot 1 will recalc and skip slot 3 as the target
If both ai mons (slot 1 and 3) see kill on both player mons (slot 0 and 2), slot 1 will randomly decide between slot 0 and 2. Then Slot 3 decides randomly. If they both target the same slot, slot 1 will recalc
Scenario 1:
double1.mp4
Scenario 2:
double2.mp4
Scenario 3:
double3.mp4