Skip to content

Commit

Permalink
Remove an extra \r\n and fix a test.
Browse files Browse the repository at this point in the history
The multipart tests hadn't been updated to expect the
content-transfer-encoding header.

Closes #40

[email protected]

Review URL: https://codereview.chromium.org//2152793003 .
  • Loading branch information
nex3 committed Jul 19, 2016
1 parent 5c2f79f commit eb11c61
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 0.11.4-dev
## 0.11.3+9

* Fix an error in multipart_test.
* Remove an extra newline in multipart chunks.

## 0.11.3+8

Expand Down
2 changes: 1 addition & 1 deletion lib/src/multipart_request.dart
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class MultipartRequest extends BaseRequest {
if (!isPlainAscii(value)) {
header = '$header\r\n'
'content-type: text/plain; charset=utf-8\r\n'
'content-transfer-encoding: binary\r\n';
'content-transfer-encoding: binary';
}
return '$header\r\n\r\n';
}
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: http
version: 0.11.4-dev
version: 0.11.3+9
author: "Dart Team <[email protected]>"
homepage: https://github.com/dart-lang/http
description: A composable, Future-based API for making HTTP requests.
Expand Down
1 change: 0 additions & 1 deletion test/multipart_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ void main() {
content-type: text/plain; charset=utf-8
content-transfer-encoding: binary
vⱥlūe
--{{boundary}}--
'''));
Expand Down

0 comments on commit eb11c61

Please sign in to comment.