Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template to match with refactoring #26

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Update template to match with refactoring #26

merged 1 commit into from
Oct 31, 2018

Conversation

vincentducorps
Copy link
Contributor

@vincentducorps vincentducorps commented Oct 31, 2018 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 31, 2018 •
edited
Loading

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          37     37           
  Lines         919    919           
=====================================
  Hits          919    919

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38abf4...0ed9da3. Read the comment docs.

@rhwilr rhwilr merged commit 132beee into rhwilr:master Oct 31, 2018
@rhwilr
Copy link
Owner

rhwilr commented Oct 31, 2018

Oh no, how could I miss this? I'm so sorry.
Thank you so much for fixing this issue. I will add a test, so this can not happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentducorps @rhwilr