Make the playground's right pane content sticky #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the content styling for the playground's right pane to be sticky so that it stays in view when at the bottom of a long workflow file. Also toss in a fix for a link in the contributing guidelines.
|
Thanks. I'll try this branch later. |
rhysd
approved these changes
Dec 27, 2022
|
I apologize for the delay. Today I checked on Chrome/Firefox/Safari locally and this worked greatly. Thank you for making this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put this together quickly after pasting a workflow file into the playground and being briefly confused that the lint results disappeared (they were at the top of the page).
This updates the styling on the content of the playground's right pane to be sticky so that it stays in view when at the bottom of a long workflow file:
Screencast.from.05-12-22.21.59.58.webm
Note that this is arguably worse UX if there's many lint results (and a long workflow file) as you now have to scroll past the entire workflow file to get to the lint results near the bottom:
Screencast.from.05-12-22.22.06.33.webm
I also included a fix for a link in the contributing guidelines.