Stop debugging on program end - Fix microsoft#11

rianadon · Jun 19, 2017 · 8f2d82a · 8f2d82a
1 parent 9724496
commit 8f2d82a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/nodeDebugAdapter.ts b/src/nodeDebugAdapter.ts
@@ -197,6 +197,16 @@ export class NodeDebugAdapter extends ChromeDebugAdapter {
         super.commonArgs(args);
     }
 
+    protected hookConnectionEvents(): void {
+        super.hookConnectionEvents();
+
+        this.chrome.Runtime.onExecutionContextDestroyed(params => {
+            if (params.executionContextId === 1) {
+                this.terminateSession('Program ended');
+            }
+        });
+    }
+
     protected async doAttach(port: number, targetUrl?: string, address?: string, timeout?: number): Promise<any> {
         await super.doAttach(port, targetUrl, address, timeout);
         this.beginWaitingForDebuggerPaused();

diff --git a/test/adapter.test.ts b/test/adapter.test.ts
@@ -58,8 +58,7 @@ suite('Node Debug Adapter etc', () => {
     });
 
     suite('launch', () => {
-		// #11
-        test.skip('should run program to the end', () => {
+        test('should run program to the end', () => {
             const PROGRAM = path.join(DATA_ROOT, 'program.js');
 
             return Promise.all([