Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstract method not implemented error; Fix parameter checking; #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Daic115
Copy link

@Daic115 Daic115 commented Oct 3, 2022

修复2个使用MongodbRecorder遇到的问题与解决:

  • MongodbPersistProvider 的抽象方法 should_resumeshould_run_init 未实现报错;
    • 在rqalpha中没找到这两个属性的引用,参考DiskPersistProvider 默认返回 False;
  • 使用MongodbRecorder 时不传入 persist_folder 时会报错;
    • mongo不需要此参数,修改 start_up 函数,并将 _set_env_and_data_source 中的cfg检查统一迁移至 start_up

self._fs.delete(grid_out._id)
if key == "mod_sys_analyser":
self._store_performance(value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要做这个操作

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants