Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /Zi from MSVC build #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

expipiplus1
Copy link

This seems like an option better set externally by the user if they desire separate debug info

Furthermore, this prevents building miniz with sccache enabled, see mozilla/sccache#963

This seems like an option better set externally by the user if they desire separate debug info

Furthermore, this prevents building miniz with sccache enabled, see mozilla/sccache#963
@expipiplus1
Copy link
Author

An alternative would be to set the MSVC_DEBUG_INFORMATION_FORMAT property on the target, this would still set it from miniz, but allow it to be more easily changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant