Add support for new GlyphRange format introduced in v3.6 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azeirah
changed the title
|
Maybe it would be wise adding a docstring to the GlyphRange documenting version differences as to not confuse consumers of the library why start is -1 |
|
Hi @Azeirah sorry for the delay reviewing/merging this, I'm away a lot during August but will get back to it in a couple of weeks if not before :) |
|
No worries, I manage my own fork of this repo for whatever functionality I need. I just want to make sure anything I add or improve is also added back upstream. |
Thanks! Now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
glyph_range_from_streamto handle glyphrange version=1 introduced in ReMarkable beta v3.6See: #14