Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoder crashes without error message #81

Closed
quamt opened this issue Aug 28, 2022 · 3 comments
Closed

Encoder crashes without error message #81

quamt opened this issue Aug 28, 2022 · 3 comments

Comments

@quamt
Copy link

quamt commented Aug 28, 2022

When encoding a video with the below options in option file

--avhw
--codec hevc
--qvbr 3000
--qvbr-quality 19
--quality best
--output-depth 10
--max-bitrate 3000
--bframes 4
--ref  8
--b-pyramid
--i-adapt
--b-adapt
--weightb
--weightp
--mbbrc
--adapt-ltr
--sao all
--audio-copy
--output-res -2x1080
--vpp-resize auto
--vpp-resize-mode quality
--input-analyze 60
--vpp-edgelevel strength=10.0,threshold=16.0,black=0,white=0
--ssim
--psnr

The encoder ends at random points of the video.
When I remove

--ssim
--psnr

It encodes normal.
Please let me know if you need a log file and which log level.

@quamt
Copy link
Author

quamt commented Aug 31, 2022

I did some more testing, strangely it seems to happen even with below option file

--avhw
--codec hevc
--qvbr 3000
--qvbr-quality 19
--quality best
--output-depth 10
--max-bitrate 3000
--bframes 4
--ref  8
--b-pyramid
--sao none
--audio-copy
--vpp-edgelevel strength=10,threshold=16.0,black=0,white=0
--ssim
--psnr

I tested psnr and ssim seperately and same crash.

rigaya added a commit that referenced this issue Sep 1, 2022
これまでssim,psnr用のデコード処理はメインスレッドとは別のスレッドで実行していたが、これが原因で不安定になり、
結果が安定しなかったり、デコード結果の取得に失敗したり、eventの待機に失敗したり、最悪異常終了するなどの問題があった。
そこで、デコード処理もメインスレッドで実行するよう変更した。
rigaya added a commit that referenced this issue Sep 1, 2022
これまでssim,psnr用のデコード処理はメインスレッドとは別のスレッドで実行していたが、これが原因で不安定になり、
結果が安定しなかったり、デコード結果の取得に失敗したり、eventの待機に失敗したり、最悪異常終了するなどの問題があった。
そこで、デコード処理もメインスレッドで実行するよう変更した。
@rigaya
Copy link
Owner

rigaya commented Sep 1, 2022

Although I was not able to reproduce the encoder crash, I think it's probably caused by --ssim and --psnr, as the calculated results were unstable.

I have made changes to improve stability of --ssim and --psnr in QSVEnc 7.14, I hope this will fix.

@quamt
Copy link
Author

quamt commented Sep 2, 2022

Ok. I run a few tests with latest 7.14 and no more crashing.
Thank you.

@quamt quamt closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants