Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3 typing to the quilbase module #1027

Closed
karalekas opened this issue Oct 1, 2019 · 2 comments
Closed

Add Python 3 typing to the quilbase module #1027

karalekas opened this issue Oct 1, 2019 · 2 comments
Assignees
@appleby
Labels
quality 🎨 Improve code quality.
Milestone
v2.13

Comments

@karalekas
Copy link
Contributor

Following on issue #988, which is being addressed in PR #999 (this PR adds typing for both gates.py and quilatom.py), this issue is for adding Python 3 typing to the quilbase.py, which is another critical component of the pyQuil library. Once this issue is addressed, we will begin using mypy as part of the CI for files that have been converted (see #1006).
@karalekas karalekas added the quality 🎨 Improve code quality. label Oct 1, 2019
@karalekas karalekas added this to the v2.13 milestone Oct 1, 2019
appleby added a commit that referenced this issue Oct 9, 2019
@appleby
Add type annotations for the quilbase module
b86a65b 
Resolves #1027
@rht
Copy link
Contributor

rht commented Oct 23, 2019

Is #147 relevant? I can resurrect the PR, with Python 3 PEP484 syntax instead of Python 2-style comments.

appleby added a commit that referenced this issue Oct 30, 2019
@appleby
Add type annotations for the quilbase module
91967cc 
Resolves #1027
appleby added a commit that referenced this issue Oct 30, 2019
@appleby
Add type annotations for the quilbase module
7edfc8a 
Resolves #1027
@karalekas
Copy link
Contributor Author

fixed in #999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@appleby appleby

Labels
quality 🎨 Improve code quality.
Projects
None yet
Milestone
v2.13
Development

No branches or pull requests
3 participants
@appleby @rht @karalekas