feat: pyquil v4 upgrade #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Context: qiskit-rigetti/qiskit_rigetti/_qcs_job.py Line 99 in fa3daa7 # qasm value
'OPENQASM 2.0;\ninclude "qelib1.inc";\nqreg q[3];\ncreg ro[2];\nmeasure q[0] -> ro[0];\nmeasure q[1] -> ro[1];' |
jselig-rigetti
commented
Sep 21, 2023
| Clbit(ro_reg, clbit.index): loc._replace(registers=[ro_reg]) | ||
| for clbit, loc in circuit._clbit_indices.items() | ||
| if clbit.register.name == orig_readout_name | ||
| } |
There was a problem hiding this comment.
Simplified this function overall, but I only had to muck about here in the first place because the prior implementation hadn't altered _clbit_indices, which became necessary somewhere along the way.
notmgsk
approved these changes
Sep 21, 2023
MarquessV
approved these changes
Sep 21, 2023
jselig-rigetti
changed the title
|
🎉 This PR is included in version 0.4.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
Updates pyquil to v4 and fixes breaking changes