Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with the refactored config and dict_compiler #177

Merged
merged 5 commits into from
Feb 20, 2018
Merged

Conversation

lotem
Copy link
Member

@lotem lotem commented Feb 19, 2018

Fixes #176

@lotem lotem requested a review from a team February 19, 2018 13:53
@nameoverflow
Copy link
Member

Seems that my custom schema (wubi98 in user directory) still down, nothing generated.

@lotem
Copy link
Member Author

lotem commented Feb 19, 2018

@nameoverflow Fixed the issue building user schema. Please take another look.

@nameoverflow
Copy link
Member

nameoverflow commented Feb 20, 2018

Looks good.

@lotem lotem merged commit 202b01f into master Feb 20, 2018
@lotem lotem deleted the develop branch February 20, 2018 14:06
@Prcuvu
Copy link
Contributor

Prcuvu commented Feb 20, 2018

@lotem Perhaps it is time to draft the 1.2.10 release. Please take time to update ChangeLog.

@lotem
Copy link
Member Author

lotem commented Feb 20, 2018

@Prcuvu It's on the way https://github.com/rime/librime/tree/changelog
Shall we include #178 in the release?

@Prcuvu
Copy link
Contributor

Prcuvu commented Feb 21, 2018

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants