fixed: _RimeParseStringOptWithFallback output value error, when load settings from schema. rime#976 #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d settings from schema. rime#976
3 tasks
determ1ne
reviewed
Jul 27, 2023
RimeWithWeasel/RimeWithWeasel.cpp
Outdated
| @@ -805,21 +805,21 @@ static void _UpdateUIStyle(RimeConfig* config, UI* ui, bool initialize) | |||
| {std::string("preview"), UIStyle::PREVIEW}, | |||
| {std::string("preview_all"), UIStyle::PREVIEW_ALL} | |||
| }; | |||
| _RimeParseStringOptWithFallback(config, "style/preedit_type", style.preedit_type, _preeditMap, UIStyle::COMPOSITION); | |||
| _RimeParseStringOptWithFallback(config, "style/preedit_type", style.preedit_type, _preeditMap, style.preedit_type); | |||
There was a problem hiding this comment.
这里 style.preedit_type 的初始值是怎么设定的
There was a problem hiding this comment.
呃，似乎就直接不用fallback也可以的感觉了，修改了一下。
fxliang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #976