Speed-up HTML escaping a little bit #100
Conversation
rinja/src/html.rs
Outdated
| const ESCAPED_BUF_LEN: usize = b"&#__;".len(); | ||
|
|
||
| #[test] | ||
| fn simple() { |
There was a problem hiding this comment.
Please pick a better name. Not very helpful if it ever fails. 😉
There was a problem hiding this comment.
If "simple" is broken, then "simply everything" is broken? :D Changed.
There was a problem hiding this comment.
Try explaining that to future you. 😛
rinja/src/html.rs
Outdated
| } | ||
|
|
||
| const MIN_CHAR: u8 = b'"'; | ||
| const MAX_CHAR: u8 = b'>'; | ||
| /// If the character needs HTML escaping, then return the decimal representation of the codepoint. |
There was a problem hiding this comment.
| /// If the character needs HTML escaping, then return the decimal representation of the codepoint. | |
| /// Returns the decimal representation of the codepoint if the character needs HTML escaping. |
rinja/src/html.rs
Outdated
| } | ||
|
|
||
| /// For characters that need HTML escaping, the codepoint formatted as decimal digits, |
There was a problem hiding this comment.
I think a word is missing here:
| /// For characters that need HTML escaping, the codepoint formatted as decimal digits, | |
| /// For characters that need HTML escaping, the codepoint is formatted as decimal digits, |
There was a problem hiding this comment.
Stupid question: How can I add a "suggested change" when I review code?
There was a problem hiding this comment.
Welcome to "github trick of the day" :D
Like this:
```suggestion
yo
```
There was a problem hiding this comment.
Ahhh, thank you! :D
```text $ cargo bench --bench escape Before the PR: [3.6464 µs 3.6512 µs 3.6564 µs] With the PR: [3.3633 µs 3.3753 µs 3.3887 µs] ``` Around 7% faster.
|
Oh, I just noticed that we are at issue #100 already! 🥳 |
|
We're doing great together. Let's hope it'll continue for a long time. 🎉 |
|
I hope so, too! :) |
|
❤️ |
Around 7% faster.