derive: make sure that static CACHE is never dropped #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assume that `static CACHE` of `Config`s is never dropped, so we only pass `&'static Config` around. It is an implementation detail in rust, that `static` variables (currently) aren't dropped at the program's termination. This PR makes sure that this behavior stays the same even if this fact is changed later on.
GuillaumeGomez
approved these changes
Aug 2, 2024
|
Good idea, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assume that
static CACHEofConfigs is never dropped, so we only pass&'static Configaround. It is an implementation detail in rust, thatstaticvariables (currently) aren't dropped at the program's termination. This PR makes sure that this behavior stays the same even if this fact is changed later on.Also, needless usages of
Arcand some someunsafecode was removed.