Fix cfg using non-existing feature

[GuillaumeGomez]

Fixes this warning:

warning: unexpected `cfg` condition value: `toml`
   --> rinja_derive/src/config.rs:576:11
    |
576 |     #[cfg(feature = "toml")]
    |           ^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `basic-toml`, `config`, `humansize`, `num-traits`, `serde`, `serde-json`, `urlencode`, `with-actix-web`, `with-axum`, `with-rocket`, and `with-warp`
    = help: consider adding `toml` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

It's been a while that this was the case though. Seems like these tests were basically never run?

[Kijewski]

I think we should update the features to suppress implicit features like some_crate, and use dep:some_crate instead. Then it will be clearer what the actual feature names are.

[GuillaumeGomez]

Good idea!

[GuillaumeGomez]

Fixed it.

[Kijewski]

I think the use of serde and basic-toml are implementation details, so the line should read config = ["dep:serde", "dep:basic-toml"], without exposing them as features.

[GuillaumeGomez]

It's what I did originally but cargo was unhappy with feature = "basic-toml". Hence why I went full in.

[Kijewski]

Oh, yeah. I guess all usages of #[cfg(feature = "toml")], #[cfg(feature = "basic-toml")], and #[cfg(feature = "serde")] are wrong in rinja_derive, and should be #[cfg(feature = "config")] instead.

[GuillaumeGomez]

Now that makes more sense. Changing to that then!

[GuillaumeGomez]

And fixed clippy too. :)

[Kijewski]

I love clippy. :) Those kind of bugs and shortcomings are impossible to find unless to read the whole code base repeatedly.

[GuillaumeGomez]

It's not clippy but rustc in this case. But yes, it's really awesome!