Remove rinja_escape and make |escape a "normal" filter

[Kijewski]

rinja_escaped was a somewhat odd beast: Some functions and types were unused, some implementation details were open for the world to see, and it was checked at runtime if a value was safe when it could be deduced at compile type. Now |escape and |safe are proper filters with nothing unusual about them, and the additional crate is gone.

This PR is a first step towards #51.

[Kijewski]

$ cd testing
$ cargo bench --bench all
Big table               time:   [345.95 µs 348.52 µs 351.07 µs]
                        change: [-6.9603% -4.5108% -2.0227%] (p = 0.00 < 0.05)
                        Performance has improved.

Teams                   time:   [479.11 ns 480.44 ns 481.86 ns]
                        change: [-9.7181% -8.6280% -7.9141%] (p = 0.00 < 0.05)
                        Performance has improved.

[GuillaumeGomez]

Looks all good to me, just one thing: could you add a test an invalid escaper please? I didn't see one. Would be also nice to improve the error message from invalid escaper for escape filter to invalid escaper `{provided_escaper_name}` for `escape` filter.

[GuillaumeGomez]

Same for no escaper defined for extension '{escaping}'.

[Kijewski]

Looks all good to me, just one thing: could you add a test an invalid escaper please?

Sure! I updated the error message to contain the unknown escaper, and added a UI test.

[GuillaumeGomez]

CI needs to be updated too.

[GuillaumeGomez]

Thinking more about this error message, I don't think it makes much sense, especially for users who just did a typo. What do you think about unknown extension 'tex'. The available extensions are 'x', 'y', 'z'. What do you think?

[Kijewski]

Good idea! Added.

[Kijewski]

CI needs to be updated too.

It is, but I failed to cargo fmt the source. :)

[GuillaumeGomez]

I thought it was a debug display before checking. XD

I think using parens would be better here:

Suggested change

	e = r#""" <empty string>"#;
	e = r#""" (empty string)"#;

One extra thought: wouldn't it be better to rely on join instead? So your first iterator could become:

let exts: String = self
            .0
            .iter()
            .flat_map(|(exts, _)| exts)
            .map(|x| if x.is_empty() { r#""" (empty string)"# else { x.as_ref() })
            .collect::<BTreeSet<&str>>()
            .into_iter()
            .join(", ");

No need for the loop below like this. And I think perf is not really a big issue here since we're errorring.

[Kijewski]

You're right. :) I use slice::join and the debug display of the extension, now.

[GuillaumeGomez]

Even better. 👍

[GuillaumeGomez]

Once merge conflict is fixed, please merge.