Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run typos to fix typos #68

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

Kijewski
Copy link
Collaborator

No description provided.

Copy link
Contributor

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Maybe we should add this check in CI directly?

@Kijewski
Copy link
Collaborator Author

Kijewski commented Jul 12, 2024

There's a ton of false positives, like converting "lits" (literals) to "list". The tools actually wants to fix the mock Latin in lorem ipsums. I don't know how much of a hassle it would be to set it up right. In most cases "lits" is a typo, just in in one case it isn't.

But maybe it's easier than I think? I guess others will have the exact same problem with other abbreviate words, and lorem ipsums are used a lot. If you want to, feel free to look into how to set it up for the CI, and I'd be happy to "borrow" the feature for other projects. ;)

@GuillaumeGomez
Copy link
Contributor

Hum, I'll open an issue for that to be done later on. Found a bug in docs.rs migration I'm trying to solve. ;)

Thanks for this PR!

@GuillaumeGomez GuillaumeGomez merged commit 70b1983 into rinja-rs:master Jul 12, 2024
17 checks passed
@Kijewski Kijewski deleted the pr-typos branch July 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants