filters: proper escaping for |linebreaks and friends
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix copy-and-paste mishap.
The generator often takes references to the values it wants to display. A bare `(Maybe)Safe<T>` won't likely be encountered.
| @@ -254,8 +254,7 @@ fn filter_block_include() { | |||
| {% endif -%} | |||
| {% endfilter -%} | |||
| "#, | |||
| ext = "html", | |||
| print = "code" | |||
| @@ -311,9 +311,6 @@ const BUILT_IN_FILTERS: &[&str] = &[ | |||
| "into_f64", | |||
| "into_isize", | |||
| "join", | |||
| "linebreaks", | |||
There was a problem hiding this comment.
Isn't it still a function in generator.rs?
There was a problem hiding this comment.
Oops, yes, of course.
There was a problem hiding this comment.
I sorted the list while re-adding the items. Looks nicer this way. :)
The filters `|linebreaks`, `|linebreaksbr` and `|paragraphbreaks`
generate HTML code to be embedded in a page. Having to specify that the
output of these filters is `|safe` is cumbersome. Also, these filters
need to operate on already escaped HTML data. This could be done by
writing `{{ s|escape|linebreaks|safe }}`.
This PR does the input and output formatting escaping for the user. The
input gets escaped for HTML (invariant of the selected escaper), and the
output gets marked as HTML safe.
Kijewski
force-pushed
the
pr-safe-paragraphbreaks
branch
from
cd54624
to
5163e38
Compare
| "urlencode_strict", | ||
| "urlencode", |
There was a problem hiding this comment.
You failed the sorting for this one. ;)
(0 is smaller than _ hehe)
There was a problem hiding this comment.
I would say the same all the time! But somehow the sort function in VS code, geany, etc. always give precedence to the longer word.
GuillaumeGomez
approved these changes
Jul 13, 2024
|
Looks all good to me, thanks! |
|
And thank your for preventing me from introducing an bug in the built-in filters list! :D |
|
Sometimes my reviews are useful. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filters
|linebreaks,|linebreaksbrand|paragraphbreaksgenerate HTML code to be embedded in a page. Having to specify that the output of these filters is|safeis cumbersome. Also, these filters need to operate on already escaped HTML data. This could be done by writing{{ s|escape|linebreaks|safe }}.This PR does the input and output formatting escaping for the user. The input gets escaped for HTML (invariant of the selected escaper), and the output gets marked as HTML safe.
Resolves #74.