-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project to Angular v13 #514
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good, and important. i would clean the any, just to be more "pretty" and more prepared for the future. added a sugestion to improve that.
return { | ||
top: result.top + marginTop, | ||
bottom: result.bottom + marginBottom, | ||
left: result.left + marginLeft, | ||
right: result.right + marginRight, | ||
width: result.width + marginLeft + marginRight, | ||
height: result.height + marginTop + marginBottom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would avoid to use anys. i like to respect the type, just to prevent possible errors on the future. for example, if we need the x and y, and we dont use, we can pass as zero. the the toJSON can be done with a simple json stringify. see an exemple in the sugestion
return { | |
top: result.top + marginTop, | |
bottom: result.bottom + marginBottom, | |
left: result.left + marginLeft, | |
right: result.right + marginRight, | |
width: result.width + marginLeft + marginRight, | |
height: result.height + marginTop + marginBottom | |
const result = { | |
x: 0, | |
y: 0, | |
top: result.top + marginTop, | |
bottom: result.bottom + marginBottom, | |
left: result.left + marginLeft, | |
right: result.right + marginRight, | |
width: result.width + marginLeft + marginRight, | |
height: result.height + marginTop + marginBottom, | |
}; | |
return { | |
...base, | |
toJSON: () => { | |
return JSON.stringify(base); | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is blocking everyone updating to angular 13 while keeping the scroller, would it be possible to go ahead with the current implementation and creating an issue out of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rintoj is it possible to merge this branch and release a new version?
Last year I asked for a new release, because the last one was the year before. Nothing changed so it's been 2 years now. Is there any point for people to keep investing their time developing in this project? Unless someone forks this and starts releasing then we should all move on to another component. |
@iharbeck published an angular 13 version on npm: Do we consider this one? |
any news on this? |
Sorry everyone I forgot about this branch. Unfortunately I do not have permissions to merge this but I may release it under our own orgs scope and update it to angular 14, I just do not know if we want to maintain the library or not. |
No description provided.