Fix/logger lifecycle #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the Logger application startup process _block_ until the logger is ready to take in requests. This means applications relying on the logger will take a tiny bit longer to boot, but we can guarantee that the log requests will not be dropped because of process spawn order. Close #82
leostera
force-pushed
the
fix/logger-lifecycle
branch
from
14abf81
to
14fb275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the Logger application startup process block until
the logger is ready to take in requests. This means applications relying
on the logger will take a tiny bit longer to boot, but we can guarantee
that the log requests will not be dropped because of process spawn
order.
Close #82