WEB3-208: Add IRiscZeroSelectable interface #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
nategraf
reviewed
Nov 7, 2024
Comment on lines
141
to
143
| require(verifier.SELECTOR() == hex"50bd1769"); | ||
| IRiscZeroSelectable selectable = IRiscZeroSelectable(verifier); | ||
| require(selectable.SELECTOR() == hex"50bd1769"); |
There was a problem hiding this comment.
I don't think this change should be required, right? Because the SELECTOR function exists on RiscZeroGroth16Verifier
Co-authored-by: Victor Graf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thi PR introduces a new interface called
IRiscZeroSelectablethat leverages the already existingSELECTORconstant of theRiscZeroGroth16Verifier(and more in general of any base implementation) to abstract from the base implementation when requiring the value of its selector (e.g., during deployment).It also adds a
Makefileto quickly deploy a local devnet and fixes some printing to create a proper TOML block e.g.,