Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SteelVerifier example #327

Open
wants to merge 1 commit into
base: feat/verifier
Choose a base branch
from

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Nov 7, 2024

Extend the token-stats example to use two sample points with only a single commitment.

@Wollac Wollac requested a review from a team as a code owner November 7, 2024 16:43
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this update to the example!

let env2 = input.into_env().with_chain_spec(&ETH_MAINNET_CHAIN_SPEC);

// Verify the first commitment.
SteelVerifier::new(&env2).verify(env1.commitment());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear here how env1 and env2 and are related. I guess I'd assume env2 needs to be a more recent block than env1, but the API does not make this obvious (I'm actually not even sure myself that this is correct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants