Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move opcode of zvb* #236

Merged
merged 2 commits into from
Mar 2, 2024
Merged

move opcode of zvb* #236

merged 2 commits into from
Mar 2, 2024

Conversation

Lucas-Wye
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (275f72a) to head (7320558).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files           3        3           
  Lines         642      642           
=======================================
  Hits          596      596           
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rv_zvbb Outdated
# https://github.com/riscv/riscv-crypto/blob/main/doc/vector/riscv-crypto-vector-zvbb.adoc

vand.vv 31..26=0x01 vm vs2 vs1 14..12=0x0 vd 6..0=0x57
vand.vx 31..26=0x01 vm vs2 rs1 14..12=0x4 vd 6..0=0x57
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two instructions are not part of Zvbb; they are part of the base V spec.

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zvbb support already exists in the unratified directory: https://github.com/riscv/riscv-opcodes/blob/f7c71810cd75d52f5d613d9f752646e82533bf09/unratified/rv_zvbb

It should be moved from the unratified directory to the root once it is ratified.

@Lucas-Wye Lucas-Wye closed this Mar 2, 2024
@Lucas-Wye Lucas-Wye reopened this Mar 2, 2024
@Lucas-Wye Lucas-Wye changed the title add opcode of riscv vector cryptography extension - zvbb move opcode of zvbb Mar 2, 2024
@sequencer
Copy link
Contributor

Zvk instructions are all ratified. Maybe move all of them out?

@Lucas-Wye Lucas-Wye changed the title move opcode of zvbb move opcode of zvb* Mar 2, 2024
@aswaterman aswaterman merged commit d3fcce5 into riscv:master Mar 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants