-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move opcode of zvb* #236
move opcode of zvb* #236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 92.83% 92.83%
=======================================
Files 3 3
Lines 642 642
=======================================
Hits 596 596
Misses 46 46 ☔ View full report in Codecov by Sentry. |
rv_zvbb
Outdated
# https://github.com/riscv/riscv-crypto/blob/main/doc/vector/riscv-crypto-vector-zvbb.adoc | ||
|
||
vand.vv 31..26=0x01 vm vs2 vs1 14..12=0x0 vd 6..0=0x57 | ||
vand.vx 31..26=0x01 vm vs2 rs1 14..12=0x4 vd 6..0=0x57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two instructions are not part of Zvbb; they are part of the base V spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zvbb support already exists in the unratified
directory: https://github.com/riscv/riscv-opcodes/blob/f7c71810cd75d52f5d613d9f752646e82533bf09/unratified/rv_zvbb
It should be moved from the unratified
directory to the root once it is ratified.
Zvk instructions are all ratified. Maybe move all of them out? |
No description provided.