Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement and Optimization:: Makefile #266

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

IIITM-Jay
Copy link
Member

@IIITM-Jay IIITM-Jay commented Jul 22, 2024

About

This PR deals with enhancement towards improvement and optimization of Makefile. It will remove redundant codes and provides better readability and clarity.

Added/ Modified Changes

Improvements are done keeping in mind the following potential areas:

  1. Redundant: Declare multiple .PHONY targets in a single line to make the Makefile cleaner.
  2. Clean and Readable Rule Syntax: The install rule uses a semicolon-separated command list. Use a multi-line shell command with explicit line continuation to provide much clarity.

Approach/ Techniques/ Principles Used

Fundamental principles are being used:

  1. Removal of redundant codes
  2. Multi-line shell commands
  3. Using fewer lines of code to achieve the same functionality

@IIITM-Jay
Copy link
Member Author

IIITM-Jay commented Oct 9, 2024

@aswaterman just small changes towards enhancement

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@aswaterman aswaterman merged commit 581ad6f into riscv:master Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants