Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: dynamically remove lazy addresses (#375) #429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf: dynamically remove lazy addresses (#375) #429

wants to merge 2 commits into from

Conversation

byhashdong
Copy link
Contributor

No description provided.

@byhashdong
Copy link
Contributor Author

@hai-rise Could you help with a review?

@hai-rise
Copy link
Contributor

hai-rise commented Nov 8, 2024

@byhashdong Good catch on the coinbase case! I think overall this is correct already and I saw up to 5% improvement on blocks with this pattern. Will try a few variants and leave a comment or approve soon 🙏.

@byhashdong
Copy link
Contributor Author

Sounds great! How do we evaluate the performance improvement now?

@hai-rise
Copy link
Contributor

hai-rise commented Nov 9, 2024

Sounds great! How do we evaluate the performance improvement now?

I had a quick mainnet benchmark run before the coinbase patch 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byhashdong @hai-rise