Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update opendal to 0.47.2 for gcs fix #17563

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Jul 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #17432

Update opendal to 0.47.2 for gcs fix. See apache/opendal#4806 and apache/opendal#4820.

cargo update opendal --precise 0.47.2 will downgrade the version of irrelevant crates as well so I have to manually revert the downgrade (See 34575af). I guess it is due to rust-lang/cargo#14115

For example, pyo3 specifies a range for valid dependencies for parking_lot: https://github.com/PyO3/pyo3/blob/a646a820fd3fc6211c52291de8b23a61f7ae7c22/Cargo.toml#L20

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@hzxa21 hzxa21 requested review from xxchan and wcy-fdu July 4, 2024 05:15
@hzxa21 hzxa21 requested a review from a team as a code owner July 4, 2024 05:15
@github-actions github-actions bot added the type/fix Bug fix label Jul 4, 2024
@hzxa21 hzxa21 added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Jul 4, 2024
@wcy-fdu wcy-fdu added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 6d69524 Jul 4, 2024
36 of 37 checks passed
@wcy-fdu wcy-fdu deleted the patrick/bump-opendal-0.47.2 branch July 4, 2024 06:29
hzxa21 added a commit that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCS longevity test storage error
3 participants