Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compaction): introduce new task status for serverless compaction #18575

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Sep 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

related to https://github.com/risingwavelabs/risingwave-extensions/blob/main/pkg/compaction/drive/driver.go

The driver changes the task status in two ways

  1. Send faill https://github.com/risingwavelabs/risingwave-extensions/blob/123845fc61d9815216e6647173e2af2c6e4c94cd/pkg/compaction/drive/driver.go#L312
  2. Unable to fetch the table catalogs for the task https://github.com/risingwavelabs/risingwave-extensions/blob/123845fc61d9815216e6647173e2af2c6e4c94cd/pkg/compaction/drive/driver.go#L403

This PR introduces a separate task status type to serve the serverless compaction module, to make it easier to distinguish the source of the error.

cloud side: https://github.com/risingwavelabs/risingwave-extensions/issues/66

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@@ -358,6 +358,10 @@ message CompactTask {
TRACK_SST_OBJECT_ID_FAILED = 12;
NO_AVAIL_CPU_RESOURCE_CANCELED = 13;
HEARTBEAT_PROGRESS_CANCELED = 14;

// for serverless compaction
SERVERLESS_SEND_FAIL_CANCELED = 15;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will serverless compaction controller add more error codes in the future? I am thinking whether we should have one error code only for all serverless compaction controller error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will serverless compaction controller add more error codes in the future?

I think it's possible, but not in a near future since the serverless protocol won't change frequently.

I am thinking whether we should have one error code only for all serverless compaction controller error.

I'm fine if the error message isn't lost. But seems we rely on the error code to tell the error kind, I think we'd better add more when necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it depends on whether we introduce more state to the compact task, e.g. table_catalog. As we iterate through the logic of the compact task, we may introduce more corresponding error

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Li0k Li0k added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit b1a38b3 Sep 18, 2024
18 of 19 checks passed
@Li0k Li0k deleted the li0k/storage_new_error_for_serverless_compact branch September 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants