Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udf): unlimit external udf message size #18591

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Sep 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The previous default 4MB limit by tonic seems too small. After arrow-udf/arrow-udf#62, we can finally increase it to usize::MAX.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Sep 18, 2024
@stdrc stdrc force-pushed the rc/increase-external-udf-msg-size-limit branch from 7300d47 to 36037c5 Compare September 23, 2024 03:21
Copy link
Member Author

stdrc commented Sep 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc marked this pull request as ready for review September 23, 2024 05:08
@stdrc stdrc marked this pull request as draft September 23, 2024 05:09
@stdrc stdrc force-pushed the rc/increase-external-udf-msg-size-limit branch from 36037c5 to e27e331 Compare October 10, 2024 06:14
@stdrc stdrc changed the title fix(udf): increase external udf message limit to 20MB fix(udf): unlimit external udf message size Oct 11, 2024
@stdrc stdrc force-pushed the rc/increase-external-udf-msg-size-limit branch from e27e331 to fe35d37 Compare October 11, 2024 06:30
@stdrc stdrc marked this pull request as ready for review October 11, 2024 06:31
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a warning trace or metric for udf message with large size? Can be in a separate PR.

@stdrc
Copy link
Member Author

stdrc commented Oct 11, 2024

Shall we add a warning trace or metric for udf message with large size? Can be in a separate PR.

It seems not easy to add such log/metric because messages are decoded in tonic and we don't have access to the raw messages. Currently I think we already have UDF Throughput (bytes).

@stdrc stdrc force-pushed the rc/increase-external-udf-msg-size-limit branch from fe35d37 to 90cccd0 Compare October 11, 2024 07:04
@stdrc stdrc requested a review from xxchan October 11, 2024 07:33
@stdrc stdrc added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@stdrc stdrc added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit e9d2e29 Oct 11, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/increase-external-udf-msg-size-limit branch October 11, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants