-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(udf): unlimit external udf message size #18591
Conversation
7300d47
to
36037c5
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
36037c5
to
e27e331
Compare
e27e331
to
fe35d37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a warning trace or metric for udf message with large size? Can be in a separate PR.
It seems not easy to add such log/metric because messages are decoded in tonic and we don't have access to the raw messages. Currently I think we already have |
Signed-off-by: Richard Chien <[email protected]>
fe35d37
to
90cccd0
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The previous default 4MB limit by tonic seems too small. After arrow-udf/arrow-udf#62, we can finally increase it to
usize::MAX
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.