-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(catalog): add views' dependencies in rw_depend
#18596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeXiangWang
changed the title
fix(meta): add views' dependencies in
fix(catalog): add views' dependencies in Sep 18, 2024
rw_depend
rw_depend
yezizp2012
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thx for the pr!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 19, 2024
Looks like the cherry-pick failed... |
lmatz
added
need-cherry-pick-release-2.0
and removed
need-cherry-pick-release-2.0
labels
Sep 20, 2024
arkbriar
added
need-cherry-pick-release-2.0
and removed
need-cherry-pick-release-2.0
labels
Sep 20, 2024
I'll trigger it again to verify the change to the PR cherry-picker. Will close the duplicate PR later. |
arkbriar
added
need-cherry-pick-release-2.0
and removed
need-cherry-pick-release-2.0
labels
Sep 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Co-authored-by: Kexiang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Reported by users.
Previously,
rw_depend
doesn't contain dependencies of views, which is misaligned with https://docs.risingwave.com/docs/current/rw_catalog/#available-risingwave-catalogs:~:text=between%20tables%2C%20indexes%2C-,views,-%2C%20materialized%20views%2C%20sources. This PR fixes this issue.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.