-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace icelake Transform with iceberg #18625
base: main
Are you sure you want to change the base?
feat: replace icelake Transform with iceberg #18625
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
😟
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an expression IcebergTransform which use icelake as an implementation. Can we use iceberg-rust mixed with it?
One known issue with partition is that if the table's partition changes later, we cannot write the partition value based on the expression used when creating the sink. Instead, we should use Iceberg's hidden partition capability to calculate it ourselves. |
This is already changed together in the PR
I’m aware of this issue. Let’s just do the simple “translation” first, and fix logic issue later |
5129b23
to
0b7fab2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
remove icelake in frontend and sink Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
0b7fab2
to
0658322
Compare
Ping @xxchan any updates? |
It needs more work in iceberg-rs. I'm focused on releasing shared source now, and will continue later. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
remove icelake in frontend and sink
#17548
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.