Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace icelake Transform with iceberg #18625

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

remove icelake in frontend and sink

#17548

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan marked this pull request as ready for review September 20, 2024 09:33
@xxchan xxchan requested a review from a team as a code owner September 20, 2024 09:33
@xxchan xxchan requested a review from stdrc September 20, 2024 09:33
Copy link
Member Author

xxchan commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xxchan
Copy link
Member Author

xxchan commented Sep 23, 2024

😟

--- STDERR:              risingwave_planner_test::planner_test_runner sink ---
  | thread '<unnamed>' panicked at src/connector/src/connector_common/iceberg/mock_catalog.rs:279:26:
  | called `Result::unwrap()` on an `Err` value: FeatureUnsupported => Can't create table with partition spec now
 

<br class="Apple-interchange-newline">

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an expression IcebergTransform which use icelake as an implementation. Can we use iceberg-rust mixed with it?

@chenzl25
Copy link
Contributor

One known issue with partition is that if the table's partition changes later, we cannot write the partition value based on the expression used when creating the sink. Instead, we should use Iceberg's hidden partition capability to calculate it ourselves.

@xxchan
Copy link
Member Author

xxchan commented Sep 24, 2024

We have an expression IcebergTransform which use icelake as an implementation. Can we use iceberg-rust mixed with it?

This is already changed together in the PR

One known issue with partition is that if the table's partition changes later, we cannot write the partition value based on the expression used when creating the sink. Instead, we should use Iceberg's hidden partition capability to calculate it ourselves.

I’m aware of this issue. Let’s just do the simple “translation” first, and fix logic issue later

@stdrc stdrc changed the title feat: replace icelake Tramsform with iceberg feat: replace icelake Transform with iceberg Sep 24, 2024
@xxchan xxchan force-pushed the 09-20-refactor_replace_icelake_with_iceberg_in_frontend branch from 5129b23 to 0b7fab2 Compare September 25, 2024 02:49
@xxchan xxchan changed the base branch from main to xxchan/good-rabbit September 25, 2024 02:49
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Base automatically changed from xxchan/good-rabbit to main September 25, 2024 06:20
@graphite-app graphite-app bot requested a review from a team September 25, 2024 06:20
remove icelake in frontend and sink

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan force-pushed the 09-20-refactor_replace_icelake_with_iceberg_in_frontend branch from 0b7fab2 to 0658322 Compare September 25, 2024 13:00
@fuyufjh
Copy link
Member

fuyufjh commented Oct 17, 2024

Ping @xxchan any updates?

@xxchan
Copy link
Member Author

xxchan commented Oct 17, 2024

It needs more work in iceberg-rs. I'm focused on releasing shared source now, and will continue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants