Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: vnode count chaos test in e2e madsim #19250

Open
wants to merge 10 commits into
base: bz/project-set-error-fix-again
Choose a base branch
from

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Nov 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Introduce a new CLI arg --random-vnode-count for madsim e2e tests, which sets the STREAMING_MAX_PARALLELISM to a random value before running each DDL statement.

This covers the behavior of multiple jobs with varying vnode counts within a single cluster, especially when they have dependencies in the streaming graph.

Added as a new step in main-cron.


An example of passed run in PR workflow: https://buildkite.com/risingwavelabs/pull-request/builds/61753#01930563-f129-4363-9599-7b25af97510a

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@graphite-app graphite-app bot requested a review from a team November 4, 2024 10:03
@BugenZhao BugenZhao changed the base branch from main to bz/scheduler-refine-for-var-vnode-count November 5, 2024 09:47
Copy link
Member Author

BugenZhao commented Nov 5, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on Graphite Graphite

@BugenZhao BugenZhao force-pushed the bz/scheduler-refine-for-var-vnode-count branch from 90ddcfc to 289d0cb Compare November 5, 2024 09:59
@BugenZhao BugenZhao force-pushed the bz/vnode-count-chaos-test branch 8 times, most recently from fba9108 to ac80a0f Compare November 6, 2024 09:05
@BugenZhao BugenZhao force-pushed the bz/scheduler-refine-for-var-vnode-count branch from c3f6718 to 8a5a086 Compare November 7, 2024 06:07
@BugenZhao BugenZhao force-pushed the bz/vnode-count-chaos-test branch 3 times, most recently from 17276bb to 16eecea Compare November 7, 2024 07:39
@BugenZhao BugenZhao changed the title feat(ci): vnode count chaos test [WIP] feat(ci): vnode count chaos test in e2e madsim Nov 7, 2024
@BugenZhao BugenZhao force-pushed the bz/scheduler-refine-for-var-vnode-count branch from 2273508 to 840f383 Compare November 8, 2024 07:11
Base automatically changed from bz/scheduler-refine-for-var-vnode-count to main November 12, 2024 03:30
@graphite-app graphite-app bot requested a review from a team November 12, 2024 03:30
@BugenZhao BugenZhao changed the title feat(ci): vnode count chaos test in e2e madsim test: vnode count chaos test in e2e madsim Nov 12, 2024
@github-actions github-actions bot added the component/test Test related issue. label Nov 12, 2024
@BugenZhao
Copy link
Member Author

Revealed a new bug (#19352), will fix in #19353.

@BugenZhao BugenZhao changed the base branch from main to bz/project-set-error-fix-again November 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants