-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqlsmith): generate ternary and variadic functions #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4572 +/- ##
========================================
Coverage 74.23% 74.24%
========================================
Files 854 858 +4
Lines 127235 127347 +112
========================================
+ Hits 94448 94543 +95
- Misses 32787 32804 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kwannoel
requested review from
marvenlee2486,
neverchanje and
lmatz
and removed request for
marvenlee2486
August 10, 2022 14:43
lmatz
approved these changes
Aug 10, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
split_part
). Other ternary / quaternary functions are already generated inmake_general_expr
.ExprNode::Type
.https://github.com/singularity-data/risingwave/blob/b596d4d80f725a2c2cb86b628104b334caf00f87/src/tests/sqlsmith/src/expr.rs#L170
concat / concat_ws
.This can be done as an improvement
(already tracked Tracking Issue: Fix Sqlsmith workarounds / refinements / bugs #3896 ),
but there are many unit / e2e test cases already for
concat / concat_ws
with implicit casts.Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)