Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlsmith): generate ternary and variadic functions #4572

Merged
merged 9 commits into from
Aug 10, 2022

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Aug 10, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #4572 (b596d4d) into main (5796692) will increase coverage by 0.00%.
The diff coverage is 73.16%.

@@           Coverage Diff            @@
##             main    #4572    +/-   ##
========================================
  Coverage   74.23%   74.24%            
========================================
  Files         854      858     +4     
  Lines      127235   127347   +112     
========================================
+ Hits        94448    94543    +95     
- Misses      32787    32804    +17     
Flag Coverage Δ
rust 74.24% <73.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/rpc/service/task_service.rs 0.00% <0.00%> (ø)
src/common/src/util/mod.rs 0.00% <ø> (ø)
src/common/src/util/ordered/serde.rs 96.21% <ø> (ø)
src/compute/src/server.rs 0.00% <ø> (ø)
src/connector/src/source/kafka/mod.rs 0.00% <ø> (ø)
src/connector/src/source/kinesis/mod.rs 0.00% <ø> (ø)
src/connector/src/source/pulsar/mod.rs 0.00% <ø> (ø)
src/expr/src/expr/expr_unary.rs 68.86% <ø> (ø)
src/expr/src/vector_op/cast.rs 72.92% <0.00%> (-2.08%) ⬇️
src/frontend/src/binder/struct_field.rs 76.81% <ø> (ø)
... and 121 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwannoel kwannoel marked this pull request as ready for review August 10, 2022 14:42
@kwannoel kwannoel requested review from marvenlee2486, neverchanje and lmatz and removed request for marvenlee2486 August 10, 2022 14:43
@mergify mergify bot merged commit 4d2db18 into main Aug 10, 2022
@mergify mergify bot deleted the kwannoel/gen-tern-var-fn branch August 10, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants