perf(agg): reuse existing agg calls while building LogicalAgg
#8200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
kwannoel
reviewed
Feb 27, 2023
Signed-off-by: Richard Chien <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #8200 +/- ##
==========================================
- Coverage 71.71% 71.71% -0.01%
==========================================
Files 1130 1130
Lines 182321 182305 -16
==========================================
- Hits 130754 130733 -21
- Misses 51567 51572 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BugenZhao
reviewed
Feb 27, 2023
| └─StreamGlobalSimpleAgg { aggs: [count, sum0(count), count(bid.auction)] } | ||
| └─StreamExchange { dist: Single } | ||
| └─StreamProject { exprs: [bid.auction, count] } | ||
| └─StreamAppendOnlyHashAgg { group_key: [bid.auction], aggs: [count, count] } |
There was a problem hiding this comment.
Seems we still have 2 counts here? 👀
There was a problem hiding this comment.
That's because the internal count inserted when building streaming plan. Will get rid of it later (#8197).
Closed
This was referenced Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, fix #8196.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note