Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd_all): sort component strings in err msg #8219

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

jon-chuang
Copy link
Contributor

@jon-chuang jon-chuang commented Feb 28, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

clearer err msg

> ./target/debug/risingwave 
Error: unknown target: risingwave
Please either:
* set `RW_NODE` env variable (`RW_NODE=<component>`)
* create a symbol link to `risingwave` binary (ln -s risingwave <component>)
* start with subcommand `risingwave <component>``
with one of the following: ["compactor", "compactor-node", "compactor_node", "compute", "compute-node", "compute_node", "ctl", "frontend", "frontend-node", "frontend_node", "meta", "meta-node", "meta_node", "play", "playground", "risectl"]

@JuchangGit hope this is clearer for you.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.

Related

Should fix: #8211

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #8219 (65e0084) into main (de37916) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8219      +/-   ##
==========================================
- Coverage   71.69%   71.69%   -0.01%     
==========================================
  Files        1131     1131              
  Lines      182332   182332              
==========================================
- Hits       130723   130718       -5     
- Misses      51609    51614       +5     
Flag Coverage Δ
rust 71.69% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cmd_all/src/bin/risingwave.rs 1.36% <ø> (ø)
src/batch/src/task/task_execution.rs 51.62% <0.00%> (-0.51%) ⬇️
src/common/src/field_generator/mod.rs 75.00% <0.00%> (-0.50%) ⬇️
src/storage/src/hummock/compactor/mod.rs 80.38% <0.00%> (-0.20%) ⬇️
src/stream/src/executor/aggregation/minput.rs 96.25% <0.00%> (-0.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lmatz lmatz added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit 108082e Feb 28, 2023
@lmatz lmatz deleted the jon/sort-component-strings branch February 28, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: better hint for component names in risingwave binary
2 participants