-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): warn unrecognized field instead of panicking #8325
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8325 +/- ##
==========================================
- Coverage 71.62% 71.62% -0.01%
==========================================
Files 1135 1135
Lines 185458 185468 +10
==========================================
- Hits 132835 132833 -2
- Misses 52623 52635 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
#[serde(flatten)] | ||
pub unrecognized: HashMap<String, Value>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very intelligent. 😄 serde-rs/serde#941
We're now using the GitHub merge queue. 🥺 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
For backward compatibility, when we deprecate a config it should still be acceptable from the config file. A demo:
Output is
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
Unrecognized fields in the configuration file will generate a warning log instead of causing panic.