Skip to content

Commit

Permalink
fix: moved log cleaning to scheduled func. fixed bug with new furiosa…
Browse files Browse the repository at this point in the history
… movie
  • Loading branch information
dreulavelle committed Sep 1, 2024
1 parent bbc5ce7 commit 475f934
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 23 deletions.
6 changes: 3 additions & 3 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/program/program.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from program.settings.models import get_version
from program.updaters import Updater
from utils import data_dir_path
from utils.logger import logger, scrub_logs
from utils.logger import logger, log_cleaner
from utils.event_manager import EventManager
import utils.websockets.manager as ws_manager

Expand Down Expand Up @@ -120,7 +120,6 @@ def start(self):
settings_manager.save()

self.initialize_services()
scrub_logs()

max_worker_env_vars = [var for var in os.environ if var.endswith("_MAX_WORKERS")]
if max_worker_env_vars:
Expand Down Expand Up @@ -262,6 +261,7 @@ def _schedule_functions(self) -> None:
"""Schedule each service based on its update interval."""
scheduled_functions = {
self._retry_library: {"interval": 60 * 10},
log_cleaner: {"interval": 60 * 60},
vacuum_and_analyze_index_maintenance: {"interval": 60 * 60 * 24},
}

Expand Down
4 changes: 2 additions & 2 deletions src/utils/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from program.db.db_functions import hard_reset_database
from program.settings.manager import settings_manager
from program.libraries.symlink import fix_broken_symlinks
from utils.logger import logger, scrub_logs
from utils.logger import logger, log_cleaner


def handle_args():
Expand Down Expand Up @@ -42,7 +42,7 @@ def handle_args():
exit(0)

if args.clean_logs:
scrub_logs()
log_cleaner()
logger.info("Cleaned old logs.")
exit(0)

Expand Down
17 changes: 1 addition & 16 deletions src/utils/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,21 +73,6 @@ def get_log_settings(name, default_color, default_icon):
"<fg #990066>{module}</fg #990066>.<fg #990066>{function}</fg #990066> - <level>{message}</level>"
)

# handlers = {
# "sink": log_filename,
# "level": level,
# "format": log_format,
# "rotation": "50 MB",
# "retention": "8 hours",
# "compression": None,
# "backtrace": False,
# "diagnose": True,
# "enqueue": True,
# }

# if LOG_ENABLED:
# handlers.append(log_filename)

logger.configure(handlers=[
{
"sink": sys.stderr,
Expand Down Expand Up @@ -122,7 +107,7 @@ def get_log_settings(name, default_color, default_icon):
logger.add(WebSocketHandler(), format=log_format)


def scrub_logs():
def log_cleaner():
"""Remove old log files based on retention settings."""
try:
logs_dir_path = data_dir_path / "logs"
Expand Down

0 comments on commit 475f934

Please sign in to comment.