test: add tests for symlink creation #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found it a bit hard to change the code here without tests, so I added some. This also found a couple of bugs: - `update_item_folder` was causing some weird behaviours with files in the rclone root, and also when `alternative_folder` was used. I can't see anywhere that's required, so I removed it. - There were two different, conflicting ways of finding the media in the rclone path. I removed the more simplistic one. I also added some type checks / empty value checks and marked private methods as such.
the-eversio
commented
Oct 2, 2024
the-eversio
commented
Oct 2, 2024
| @@ -217,7 +208,6 @@ def _symlink(self, item: Union[Movie, Episode]) -> bool: | |||
| extension = os.path.splitext(item.file)[1][1:] | |||
| symlink_filename = f"{filename}.{extension}" | |||
| destination = self._create_item_folders(item, symlink_filename) | |||
| source = os.path.join(self.rclone_path, item.folder, item.file) | |||
There was a problem hiding this comment.
Removed because the logic is different to _get_item_path, which I use instead now.
Gaisberg
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Description:
I found it a bit hard to change the code here without tests, so I added some. This also found a couple of bugs:
update_item_folderwas causing some weird behaviours with files in the rclone root, and also whenalternative_folderwas used. I can't see anywhere that's required, so I removed it.I also added some type checks / empty value checks and marked private methods as such.
This should merge cleanly with #758, which removes a bunch of duplicate code also related to symlinks.