Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: start refactor on id handling #787

Merged
merged 51 commits into from
Oct 18, 2024
Merged

feat: start refactor on id handling #787

merged 51 commits into from
Oct 18, 2024

Conversation

dreulavelle
Copy link
Member

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

Description:

Gaisberg
Gaisberg requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@Gaisberg Gaisberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, one serious thing regarding possible duplicates being stored into database, others are just nitpicking.

src/controllers/items.py Outdated Show resolved Hide resolved
src/controllers/items.py Outdated Show resolved Hide resolved
src/controllers/items.py Outdated Show resolved Hide resolved
src/program/db/db_functions.py Outdated Show resolved Hide resolved
src/program/db/db_functions.py Outdated Show resolved Hide resolved
src/utils/event_manager.py Outdated Show resolved Hide resolved
src/utils/event_manager.py Outdated Show resolved Hide resolved
src/utils/event_manager.py Outdated Show resolved Hide resolved
src/utils/event_manager.py Outdated Show resolved Hide resolved
src/utils/event_manager.py Outdated Show resolved Hide resolved
dreulavelle and others added 19 commits October 15, 2024 03:51
@dreulavelle
fix: more work.. need to
2380635
@dreulavelle
Merge branch 'main' into refactor/id_handling
76ddb8a
@dreulavelle
fix: fixed session management when processing threads
aa9487d
@dreulavelle
fix: updated add_item
cca83aa
fix: fix event processing with item_id handling
1679f31
@dreulavelle
fix: attempt #1 at duplicates
1758f7b
@dreulavelle
fix: attempt #2. use same removal process as remove endpoint
3a7bc06
@dreulavelle
fix: check type first and delete duplicate shows appropriately
3a371bd
@dreulavelle
fix: repurpose deletions to work on any item
c4287b3
@dreulavelle
fix: revert duplicate changes. change retry lib back to normal, set t…
f04b697 
…o 24h
refactor: rename private methods to public, remove filtering items in…
a44c3ec 
… content services
chore: rename store_item and add prefixes to threads to indentify
b79c0c6
chore: Events to hold service, not service name, fixes multiple notif…
9fa042e 
…ications
@dreulavelle
fix: stopiter error fix
a24f511
@dreulavelle
fix: add logging...
dba1689
@dreulavelle
fix: whoops
553579e
@dreulavelle
feat: start refactor on id handling
c213680
@dreulavelle
fix: more fixes towards handling ids
49d4533
@dreulavelle
fix: more work done
47d37e6
dreulavelle and others added 21 commits October 17, 2024 20:38
@dreulavelle
fix: improved retry lib for logging
d16a71b
@dreulavelle
fix: update deps and add psutil
e2a5774
@dreulavelle
fix: more work on getting new content added
3784795
@dreulavelle
fix: fix retry/reset endpoints
163c9b4
@dreulavelle
fix: use event instead of add_item on retry endpoint
1b98548
@davidemarcoli
fix: issue with duplicate symlink detection on db init
9d81885
@dreulavelle
fix: more work.. need to
304fc6d
@dreulavelle
fix: fixed session management when processing threads
649920c
@dreulavelle
fix: updated add_item
e624ca1
fix: fix event processing with item_id handling
04e7c80
@dreulavelle
fix: attempt #1 at duplicates
069fad2
@dreulavelle
fix: attempt #2. use same removal process as remove endpoint
1e4e34f
@dreulavelle
fix: check type first and delete duplicate shows appropriately
ebd3f8e
@dreulavelle
fix: repurpose deletions to work on any item
907be80
@dreulavelle
fix: revert duplicate changes. change retry lib back to normal, set t…
309167d 
…o 24h
refactor: rename private methods to public, remove filtering items in…
42bbd8b 
… content services
chore: rename store_item and add prefixes to threads to indentify
3ac18cf
chore: Events to hold service, not service name, fixes multiple notif…
f27577d 
…ications
@dreulavelle
fix: stopiter error fix
8f18ff1
@dreulavelle
fix: add logging...
2044752
@dreulavelle
fix: whoops
c01cc2f
@dreulavelle dreulavelle marked this pull request as ready for review October 18, 2024 08:30
@dreulavelle dreulavelle merged commit 612964e into main Oct 18, 2024
3 checks passed
@dreulavelle dreulavelle deleted the refactor/id_handling branch October 18, 2024 08:31
@dreulavelle dreulavelle mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptrplan filiptrplan filiptrplan left review comments

@Gaisberg Gaisberg Awaiting requested review from Gaisberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreulavelle @filiptrplan @Gaisberg @davidemarcoli