fix typo in leadership resignation query #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
force-pushed
the
bg-fix-leadership-notify-name
branch
from
eef6cd5
to
789610f
Compare
bgentry
commented
Dec 30, 2023
| @@ -40,7 +40,7 @@ WITH currently_held_leaders AS ( | |||
| ), | |||
| notified_resignations AS ( | |||
| SELECT | |||
| pg_notify('river_leaderhip', json_build_object('name', name, 'leader_id', leader_id, 'action', 'resigned')::text), | |||
| pg_notify('river_leadership', json_build_object('name', name, 'leader_id', leader_id, 'action', 'resigned')::text), | |||
There was a problem hiding this comment.
Actually, another way to fix this would be to pass in the notification name using the in-code constant. That would ensure we're using the same value everywhere.
Thoughts?
There was a problem hiding this comment.
Yeah, good idea. It's already referenced in code anyway, so couldn't hurt just to use the same ref here.
There was a problem hiding this comment.
I’ll do this in a follow up PR, there are a couple we can get rid of
brandur
approved these changes
Dec 31, 2023
| @@ -40,7 +40,7 @@ WITH currently_held_leaders AS ( | |||
| ), | |||
| notified_resignations AS ( | |||
| SELECT | |||
| pg_notify('river_leaderhip', json_build_object('name', name, 'leader_id', leader_id, 'action', 'resigned')::text), | |||
| pg_notify('river_leadership', json_build_object('name', name, 'leader_id', leader_id, 'action', 'resigned')::text), | |||
There was a problem hiding this comment.
Yeah, good idea. It's already referenced in code anyway, so couldn't hurt just to use the same ref here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s/river_leaderhip/river_leadership🤦♂️