add UniqueSkippedAsDuplicate field to JobRow #142
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting a job, the insert may be rejected because the configured uniqueness constraints for the job are not met.
With the current API, this happens silently and without a way for the caller to check for this condition.
Since we already record the UniqueSkippedAsDuplicate in the internal dbadapter.JobInsertResult, we just have to propagate this value to the external client API.
Callers can now check the UniqueSkippedAsDuplicate field of JobRow to check for the condition described above.
This is an RFC PR to keep the discussion on #86 going. I am pretty sure this is the "least breaking" API change possible to implement this.
@bgentry @brandur please advise if you like this approach or if you have other suggestions.