Try to fix release instructions, again #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the release instructions are still wrong. When running `update-submodule-versions` changes are made to local `go.mod` files, which need to be pushed and reviewed in a pull request because of the repo's branch protection. Here, try to fix the release instructions by wrapping up the updates to `CHANGELOG.md` and the `go.mod` files into one step, and move it a little further down the instruction list to make that possible.
bgentry
approved these changes
Jan 22, 2024
brandur
added a commit
that referenced
this pull request
Jan 22, 2024
Here, as proposed by the new release instructions in #169, tee up some changes for 0.0.17, updating `CHANGELOG.md` with the new section and modifying `go.mod` files to point to the new release. Unfortunate note no. 1: the `go.mod` files change from 0.0.15 to 0.0.17 instead of starting at 0.0.16 because I accidentally botched the last release by not pushing the `go.mod` changes. Hopefully this new process will correct that so it doesn't happen again. Unfortunate note no. 2: As noted in #169, we expect the build to fail here because `go.mod` files point to a version that doesn't have a tag yet. The new `river validate` is included here (#170) so I'm also going to try a two-phase release by tagging all submodules except for `./cmd/river` with 0.0.17 first, then modifying that submodule to point to the new 0.0.17 in other modules, then do a cut and release for it separately. Kind of a pain, but as discussed at length before, this seems to be the least bad of a bunch of suboptimal options.
brandur
added a commit
that referenced
this pull request
Jan 23, 2024
Here, as proposed by the new release instructions in #169, tee up some changes for 0.0.17, updating `CHANGELOG.md` with the new section and modifying `go.mod` files to point to the new release. Unfortunate note no. 1: the `go.mod` files change from 0.0.15 to 0.0.17 instead of starting at 0.0.16 because I accidentally botched the last release by not pushing the `go.mod` changes. Hopefully this new process will correct that so it doesn't happen again. Unfortunate note no. 2: As noted in #169, we expect the build to fail here because `go.mod` files point to a version that doesn't have a tag yet. The new `river validate` is included here (#170) so I'm also going to try a two-phase release by tagging all submodules except for `./cmd/river` with 0.0.17 first, then modifying that submodule to point to the new 0.0.17 in other modules, then do a cut and release for it separately. Kind of a pain, but as discussed at length before, this seems to be the least bad of a bunch of suboptimal options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the release instructions are still wrong. When running
update-submodule-versionschanges are made to localgo.modfiles,which need to be pushed and reviewed in a pull request because of the
repo's branch protection.
Here, try to fix the release instructions by wrapping up the updates to
CHANGELOG.mdand thego.modfiles into one step, and move it alittle further down the instruction list to make that possible.