elector: resign leadership w/ WithoutCancel ctx, not background #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
reviewed
Jun 26, 2024
internal/leadership/elector.go
Outdated
| @@ -375,14 +375,14 @@ func (e *Elector) attemptResignLoop(ctx context.Context) { | |||
|
|
|||
| // This does not inherit the parent context because we want to give up leadership | |||
| // even during a shutdown. There is no way to short-circuit this. | |||
There was a problem hiding this comment.
Maybe tweak this comment a little?
bgentry
force-pushed
the
bg-elector-use-without-cancel-context
branch
from
f29d994
to
569ed24
Compare
brandur
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrowing an idea from #401, rather than using a background context for a shutdown operation that we don't want to be prematurely immediately cancelled, we can instead use a
context.WithoutCancel(ctx)to maintain non-cancel parts of the context.I also updated logger calls in here to use the
Contextvariants for consitency.