Demote many log lines from info to debug #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
commented
Jul 13, 2024
| s.Logger.DebugContext(ctx, s.Name+logPrefixRanSuccessfully, | ||
| slog.Int("num_jobs_deleted", res.NumJobsDeleted), | ||
| ) | ||
| } |
There was a problem hiding this comment.
There's some argument to be made that these changes are detrimental to debugging tests, but I generally find that if I'm debugging anything non-trivial I need to add more log statements anyway because the existing ones just aren't enough.
brandur
commented
Jul 13, 2024
| s.Logger.InfoContext(ctx, s.Name+": Rescued batch of jobs", | ||
| slog.Int64("num_jobs_discarded", res.NumJobsDiscarded), | ||
| slog.Int64("num_jobs_retried", res.NumJobsRetried), | ||
| ) |
There was a problem hiding this comment.
A couple of these services sort of had doubled up run lines. I took one half out and just left the line above.
We've had reports that a running River client can be quite a noisy affair, producing too much logging in general. Here, we move many log lines from info to debug. I suspect the most impactful is that we had a bunch in the elector and notifier that would fire quite often during run of the mill operation. I left a couple in place, although I'm not 100% sure it's the right thing: * The 5 second heartbeat loop in the client that prints job statistics. I figure that if this is the _main_ log line being emitted, with others being quite rare, it might be okay. We could also consider moving it to be more infrequent like every 10 seconds. * I left the maintenance service "done run" log lines as info for the time being, but I changed them so that they only print in case there were >0 results, so I think the result is that most of them are silent most of the time, except perhaps in an actual production situation. I figure we can try this as a pass, see how it is, and then possibly demote more if it's still annoying.
brandur
force-pushed
the
brandur-demote-log-lines
branch
from
dcd9637
to
eff824b
Compare
🤫
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had reports that a running River client can be quite a noisy
affair, producing too much logging in general.
Here, we move many log lines from info to debug. I suspect the most
impactful is that we had a bunch in the elector and notifier that would
fire quite often during run of the mill operation.
I left a couple in place, although I'm not 100% sure it's the right
thing:
The 5 second heartbeat loop in the client that prints job statistics.
I figure that if this is the main log line being emitted, with
others being quite rare, it might be okay. We could also consider
moving it to be more infrequent like every 10 seconds.
I left the maintenance service "done run" log lines as info for the
time being, but I changed them so that they only print in case there
were >0 results, so I think the result is that most of them are silent
most of the time, except perhaps in an actual production situation.
I figure we can try this as a pass, see how it is, and then possibly
demote more if it's still annoying.