Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchCompleter: batch all ops, not just completed #617

Merged
merged 1 commit into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. BatchCompleter: batch all ops, not just completed

    This adds a `JobSetStateIfRunningMany` query and corresponding driver
    API, with implementations for both pgxv5 and `database/sql`.
    
    The `BatchCompleter` was updated to use this new query and to batch
    _all_ operations, not only those moving to a `complete` state. This
    means the `AsyncCompleter` (as well as the `InlineCompleter`) are both
    now unused and could be deleted, along with their underlying queries.
    
    The intention of this is not just to facilitate improved performance
    even on snoozes, retries, errors, cancellations, etc., but also to get
    down to a single path for completions (similar to now having a single
    path for insertions).
    bgentry committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2eb03e2 View commit details
    Browse the repository at this point in the history