Added metainfo file to the installation

[xvitaly]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've updated the documentation with the relevant information (if needed)

Detailed description

• Added metainfo file to the installation because it is required by most modern Linux package managers and Flatpak.
• Switched from hardcoded directory name to CMAKE_INSTALL_DATAROOTDIR use.
• Removed the COMPONENT option from the desktop file installation entry since the file is not a development file and is always needed.
• Added missing GenericName and Comment to the desktop file.

Test plan (required)

Run the build and installation on any UNIX operating system. The desktop and metainfo files should be installed.

Closing issues

n/a

[XVilka]

@ret2libc take a look please

[karliss]

The generic name and comment in .desktop file feels somewhat redundant.

Just browsed my /usr/share/applications folder to see how it gets used in practice

a) A lot of programs didn't bother with generic name.
b) For software that have both the generic name and comment. Generic name is often a noun, but comment starts with verbs. It somewhat matches the example in .desktop file spec.

So my suggestion is doing one of the following:

• getting rid of GenericName
• replace the FOSS part in comment with a more useful information like "Reverse engineering platform based on rizin". Most of the software that you run on Linux is open source, so mentioning it in the context of .desktop isn't much of a selling point.
• in commnet use a sentence with verbs something like "Disassemble, analyze and debug executable files for various architectures."

Does anyone have an example of a desktop environment displaying the "GenericName" or "Comment" values anywhere. At least on Gnome the application menu didn't seem to use it, and more detailed view in software center was based on appdata.xml not the .desktop file content. I am not saying that it's useless, I am just curios how various desktop environments use this information.

[karliss]

Checked the .appimage from CI, and all 3 files were installed in the expected folders.

[xvitaly]

getting rid of GenericName

GenericName is heavily used by KDE Plasma. Without it, the second line of the application launcher is empty and it looks ugly.

Does anyone have an example of a desktop environment displaying the "GenericName" or "Comment" values anywhere.

The first line - Name.
The second line - GenericName.
Tooltip - Comment.

the application menu didn't seem to use it, and more detailed view in software center was based on appdata.xml not the .desktop file content

Appdata is only used by package managers. Application launchers use only desktop files.

replace the FOSS part in comment with a more useful information like "Reverse engineering platform based on rizin".

Done.